Skip to content

fix: windows builds#1248

Merged
kirillzyusko merged 25 commits intomainfrom
fix/windows-builds
Jan 12, 2026
Merged

fix: windows builds#1248
kirillzyusko merged 25 commits intomainfrom
fix/windows-builds

Conversation

@kirillzyusko
Copy link
Copy Markdown
Owner

@kirillzyusko kirillzyusko commented Dec 16, 2025

📜 Description

Added a job for building example app on windows and shortened codegen name to fix build errors.

💡 Motivation and Context

This is a continuation of #1251

In #1251 we shortened codegen name from reactnativekeyboardcontroller till keyboardcontroller. In this PR we make it even shorter: from keyboardcontroller -> RNKC. The keyboardcontroller has 18 symbols, safeareacontext (very popular lib) has 15 symbols, so our lib will exceed symbols limitation, when safeareacontext will not. Now I make length only 4 symbols. While I'm not a big fan of making variables/pathname shorter, because it makes more effort for newcomers to understand the code, but here I'm ready to sacrifice readability in favor of smaller amount of issues with complaints that builds are failing on windows.

I hope in 2026 RN team will update Ninja/CMake to newest version and this limitation will gone, but for now let's use shorter name and fix windows build errors.

Also I'd like to say few words about CI job. I've tried to assemble example app on windows runners, but I had compilation errors because of reanimated. So I went in a different direction. I create a new app and then link my lib locally to this project (just to check compilation issues). Not very elegant but it does its job - it gives me more confidence, that windows builds are not occasionally get broken 🤞

Closes #1247 #1147 #1253

📢 Changelog

CI

  • add a job for windows builds;

iOS

  • make codegen name shorter;

Android

  • make codegen name shorter;

C++

  • make codegen name shorter;

🤔 How Has This Been Tested?

Tested on CI.

📸 Screenshots (if appropriate):

Before After
image image

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko self-assigned this Dec 16, 2025
@kirillzyusko kirillzyusko added the CI CI (github actions) label Dec 16, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 16, 2025

📊 Package size report

Current size Target Size Difference
230192 bytes 230225 bytes -33 bytes 📉

@kirillzyusko
Copy link
Copy Markdown
Owner Author

Closing as I can not fix worklets building (without enabling long paths or updating ninja - which doesn't make sense since it's the same workaround that I recommended in documentation).

@kirillzyusko kirillzyusko reopened this Jan 4, 2026
Comment thread package.json
@kirillzyusko kirillzyusko added 🐛 bug Something isn't working build error ❌ Anything that triggers build errors and prevent this library from being used labels Jan 12, 2026
@kirillzyusko kirillzyusko linked an issue Jan 12, 2026 that may be closed by this pull request
@kirillzyusko kirillzyusko marked this pull request as ready for review January 12, 2026 13:00
@kirillzyusko kirillzyusko merged commit 68395bf into main Jan 12, 2026
31 of 32 checks passed
@kirillzyusko kirillzyusko deleted the fix/windows-builds branch January 12, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working build error ❌ Anything that triggers build errors and prevent this library from being used CI CI (github actions)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package name and folder paths are too long for usage with windows Windows: Build fails with "Filename longer than 260 characters" on New Architecture

1 participant