fix: windows builds#1248
Merged
kirillzyusko merged 25 commits intomainfrom Jan 12, 2026
Merged
Conversation
Contributor
📊 Package size report
|
This reverts commit b2379b3.
Owner
Author
|
Closing as I can not fix worklets building (without enabling long paths or updating ninja - which doesn't make sense since it's the same workaround that I recommended in documentation). |
kirillzyusko
commented
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Added a job for building example app on windows and shortened
codegenname to fix build errors.💡 Motivation and Context
This is a continuation of #1251
In #1251 we shortened codegen name from
reactnativekeyboardcontrollertillkeyboardcontroller. In this PR we make it even shorter: fromkeyboardcontroller->RNKC. Thekeyboardcontrollerhas 18 symbols,safeareacontext(very popular lib) has 15 symbols, so our lib will exceed symbols limitation, whensafeareacontextwill not. Now I make length only 4 symbols. While I'm not a big fan of making variables/pathname shorter, because it makes more effort for newcomers to understand the code, but here I'm ready to sacrifice readability in favor of smaller amount of issues with complaints that builds are failing on windows.I hope in 2026 RN team will update Ninja/CMake to newest version and this limitation will gone, but for now let's use shorter name and fix windows build errors.
Also I'd like to say few words about CI job. I've tried to assemble example app on windows runners, but I had compilation errors because of reanimated. So I went in a different direction. I create a new app and then link my lib locally to this project (just to check compilation issues). Not very elegant but it does its job - it gives me more confidence, that windows builds are not occasionally get broken 🤞
Closes #1247 #1147 #1253
📢 Changelog
CI
iOS
Android
C++
🤔 How Has This Been Tested?
Tested on CI.
📸 Screenshots (if appropriate):
📝 Checklist